Add official Python 3.7 support #4717
Conversation
Python 3.7 was just released [1]. This is a small change to enable support in requests. Signed-off-by: Eric Brown <[email protected]>
|
Travis doesnt' appear to support 3.7 yet: https://travis-ci.org/requests/requests/jobs/397660384 |
|
Looks like it's being worked: travis-ci/travis-ci#9815 |
|
I see nothing indicating that it's in progress on Travis' part other than an issue that non-Travis-CI employees are commenting on. |
|
Hey @ericwb, we’ll likely want this enabled for appveyor as well before we claim support for 3.7. I haven’t seen an update from them but that’d be something to look into before we merge this. |
Codecov Report
@@ Coverage Diff @@
## master #4717 +/- ##
=======================================
Coverage 66.79% 66.79%
=======================================
Files 15 15
Lines 1563 1563
=======================================
Hits 1044 1044
Misses 519 519Continue to review full report at Codecov.
|
|
According to appveyor/ci#2475, Appveyor now supports Python 3.7. |
|
@jdufresne great to hear! Once we get a working build with that, I’m happy to merge. |
|
Hey @ericwb, wanted to check in on this again if you get a minute. Otherwise, I'm going to look at cherry picking these onto master with the appveyor integration later this week. Thanks! |
|
@ericwb would you be willing to rebase this? |
|
And squash the commits too if you wouldn’t mind. Thanks! |
.travis.yml
Outdated
| @@ -22,8 +13,35 @@ jobs: | |||
| - stage: test | |||
| script: | |||
| - | | |||
| if [[ "$TRAVIS_PYTHON_VERSION" != "2.6" ]] ; then make test-readme; fi | |||
| make test-readme | |||
There was a problem hiding this comment.
This could drop the | and fit on one line
.travis.yml
Outdated
| - stage: test | ||
| script: | ||
| - | | ||
| make test-readme |
.travis.yml
Outdated
| - stage: test | ||
| script: | ||
| - | | ||
| make test-readme |
.travis.yml
Outdated
| - stage: test | ||
| script: | ||
| - | | ||
| make test-readme |
.travis.yml
Outdated
| - stage: test | ||
| script: | ||
| - | | ||
| make test-readme |
.travis.yml
Outdated
| - make ci | ||
| python: '3.7' | ||
| dist: xenial | ||
| sudo: true |
There was a problem hiding this comment.
Why do we need sudo here and does this conflict with the sudo: False declaration above?
There was a problem hiding this comment.
No, it does not. This is the only way to use xenial on Travis is to use sudo on this job alone. And xenial is the only target that has true Python 3.7. So it's not ideal (because enabling sudo is slow) but it's the best we have right now
| @@ -1,14 +1,5 @@ | |||
| sudo: false | |||
| language: python | |||
| python: | |||
There was a problem hiding this comment.
Could we get a quick explanation of the benefits/trade offs of moving from the matrix approach to this new setup?
There was a problem hiding this comment.
You mean moving from the old configuration to the more explicit matrix definition? Other than greater flexibility?
There was a problem hiding this comment.
Alright, I think this looks good to go. Thanks for seeing this all the way through, @ericwb!
|
@nateprewitt any release coming soon with python3.7 support? |
|
@mrkz, 2.19.1 should already support 3.7. This was just adding documentation stating that. |
Python 3.7 was just released [1]. This is a small change to
enable support in requests.
[1] https://docs.python.org/3.7/whatsnew/3.7.html
Signed-off-by: Eric Brown [email protected]