Update all non-major dependencies, optimized token refresh decision logic according to newly discovered mutation test scenarios #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
| datasource | package | from | to | | ---------- | --------------------------------- | ------ | ------ | | packagist | laminas/laminas-diactoros | 2.19.0 | 2.20.0 | | packagist | laminas/laminas-httphandlerrunner | 2.3.0 | 2.4.0 | | packagist | phpunit/phpunit | 9.5.25 | 9.5.26 |
Branch automerge failureThis PR was configured for branch automerge. However, this is not possible, so it has been raised as a PR instead.
|
… token needs refresh
* an empty or invalid token will produce an empty session container
* an empty session container, if not changed, will not be refreshed
* a valid token with an empty session will be left to expire anyway
* a valid token with a non-empty session will be refreshed
This also removes a mutation that caused our CI to fail:
```
1) /home/ocramius/Documents/psr7-sessions/storageless/src/Storageless/Http/SessionMiddleware.php:215 [M] NotIdentical
--- Original
+++ New
@@ @@
{
$refreshTime = $this->clock->now()->sub(new DateInterval(sprintf('PT%sS', $this->refreshTime)));
assert($refreshTime !== false);
- return $token !== null && $token->hasBeenIssuedBefore($refreshTime);
+ return $token === null && $token->hasBeenIssuedBefore($refreshTime);
}
/** @throws BadMethodCallException */
private function getTokenCookie(SessionInterface $sessionContainer) : SetCookie
[warning] Dashboard report has not been sent: The current process is not executed in a CI build
Time: 9s. Memory: 0.10GB
[ERROR] The minimum required MSI percentage should be 100%, but actual is 97.3%. Improve your tests!
```
Ocramius
changed the title
This was referenced Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
^2.19.0->^2.20.0^2.3.0->^2.4.0^9.5.25->^9.5.26Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
Read more about the use of Renovate Bot within
ocramius/*projects.