Add Config object, drop factory methods #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Slamdunk
commented
May 3, 2023
src/Storageless/Http/Config.php
Outdated
| private Clock $clock; | ||
| private SetCookie $cookie; | ||
| /** @var positive-int */ | ||
| private int $idleTimeout = 43200; |
There was a problem hiding this comment.
Added a 12h default idle timeout, where 8.x requested to be expicitely set.
Seems to me a good compromise in order to have a cleaner Config API, that now needs only a JWT\Configuration to be instantiated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR I'm all-in about this: #564 (comment)
BC break
9.0.xormasteror whatever, tell me please