Small cleanups #874
Merged
Small cleanups #874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using "match" and "return", we can just use "?" to simplify this code. Signed-off-by: Uli Schlachter <[email protected]>
This code has a constant with value 18. So far, this constant was kept as a u32. There is one place that needs this value as a usize. This conversion was done with try_into().unwrap(). This commit removes that unwrap() by changing the type of the constant to u16, which can be converted to usize via into(). Signed-off-by: Uli Schlachter <[email protected]>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #874 +/- ##
=======================================
Coverage 12.72% 12.72%
=======================================
Files 188 188
Lines 137957 137955 -2
=======================================
Hits 17559 17559
+ Misses 120398 120396 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some random stuff that hopefully improves things and that I had laying around for a while.