Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/box64/src/libtools/my_x11_xevent.c:260:13. cannot build #1938

Closed
iHad168 opened this issue Oct 14, 2024 · 2 comments
Closed

/box64/src/libtools/my_x11_xevent.c:260:13. cannot build #1938

iHad168 opened this issue Oct 14, 2024 · 2 comments

Comments

@iHad168
Copy link

iHad168 commented Oct 14, 2024

root@localhost ~/b/build (main) [2]# make install
[ 0%] Built target WRAPPERS32
[ 0%] Built target WRAPPERS
[ 11%] Built target interpreter
[ 12%] Building C object CMakeFiles/box64.dir/src/libtools/my_x11_xevent.c.o
/root/box64/src/libtools/my_x11_xevent.c: In function ‘convertXEvent’:
/root/box64/src/libtools/my_x11_xevent.c:260:13: error: a label can only be part of a statement and a declaration is not a statement
260 | register_events_t* head = register_events_head;
| ^~~~~~~~~~~~~~~~~
/root/box64/src/libtools/my_x11_xevent.c: In function ‘unconvertXEvent’:
/root/box64/src/libtools/my_x11_xevent.c:496:13: error: a label can only be part of a statement and a declaration is not a statement
496 | register_events_t* head = register_events_head;
| ^~~~~~~~~~~~~~~~~
make[2]: *** [CMakeFiles/box64.dir/build.make:1270: CMakeFiles/box64.dir/src/libtools/my_x11_xevent.c.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:102: CMakeFiles/box64.dir/all] Error 2
make: *** [Makefile:182: all] Error 2

@m1m1k4tz
Copy link

What hardware do you have? How do you reproduce this?

@ptitSeb
Copy link
Owner

ptitSeb commented Oct 15, 2024

it's more it's an old compiler (or just very strict). I'll try to fix this later, but it's just anoying to do.

devarajabc added a commit to devarajabc/box64 that referenced this issue Oct 22, 2024
Resolved a compilation error due to variable declaration within a switch-case
statement without enclosing braces. This error occurred with older GCC compilers,
which require declarations to be part of a block within switch-case constructs.

The modification ensures that the declaration of `register_events_t* head`
and the subsequent logic within the default case of the switch statement
are enclosed within braces, making the code compatible with older compilers
and adhering to good coding practices.

Resolves: ptitSeb#1938
devarajabc added a commit to devarajabc/box64 that referenced this issue Oct 22, 2024
Resolved a compilation error due to variable declaration within a switch-case
statement without enclosing braces. This error occurred with older GCC compilers,
which require declarations to be part of a block within switch-case constructs.

The modification ensures that the declaration of `register_events_t* head`
and the subsequent logic within the default case of the switch statement
are enclosed within braces, making the code compatible with older compilers
and adhering to good coding practices.

Resolves: ptitSeb#1938
devarajabc added a commit to devarajabc/box64 that referenced this issue Oct 22, 2024
Resolved a compilation error due to variable declaration within a switch-case
statement without enclosing braces. This error occurred with older GCC compilers,
which require declarations to be part of a block within switch-case constructs.

The modification ensures that the declaration of `register_events_t* head`
and the subsequent logic within the default case of the switch statement
are enclosed within braces, making the code compatible with older compilers
and adhering to good coding practices.

Resolves: ptitSeb#1938
devarajabc added a commit to devarajabc/box64 that referenced this issue Oct 22, 2024
Resolved a compilation error due to variable declaration within a switch-case
statement without enclosing braces. This error occurred with older GCC compilers,
which require declarations to be part of a block within switch-case constructs.

The modification ensures that the declaration of `register_events_t* head`
and the subsequent logic within the default case of the switch statement
are enclosed within braces, making the code compatible with older compilers
and adhering to good coding practices.

Resolves: ptitSeb#1938
devarajabc added a commit to devarajabc/box64 that referenced this issue Oct 22, 2024
Resolved a compilation error due to variable declaration within a switch-case
statement without enclosing braces. This error occurred with older GCC compilers,
which require declarations to be part of a block within switch-case constructs.

The modification ensures that the declaration of `register_events_t* head`
and the subsequent logic within the default case of the switch statement
are enclosed within braces, making the code compatible with older compilers
and adhering to good coding practices.

Resolves: ptitSeb#1938
devarajabc added a commit to devarajabc/box64 that referenced this issue Oct 22, 2024
Fixed compilation errors related to variable declarations within
switch-case statements without enclosing braces. This adjustment
ensures compatibility with older versions of compiler.

Resolves: ptitSeb#1938
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants