Merge pull request #53 from salomonelli/master

FIX bug #52 query.$ fires on remove
pubkey · Feb 12, 2017 · 533f86d · 533f86d
2 parents b92521e + 032b4ea
commit 533f86d
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 1 deletion.
diff --git a/src/RxQuery.js b/src/RxQuery.js
@@ -84,7 +84,7 @@ class RxQuery {
             this._subject = new util.Rx.BehaviorSubject(null);
             this._obsRunning = false;
             const collection$ = this.collection.$
-                .filter(cEvent => ['RxCollection.insert', 'RxDocument.save'].includes(cEvent.data.op))
+                .filter(cEvent => ['RxCollection.insert', 'RxDocument.save', 'RxDocument.remove'].includes(cEvent.data.op))
                 .startWith(1)
                 .filter(x => !this._obsRunning)
                 .do(x => this._obsRunning = true)

diff --git a/test/node/Observe.test.js b/test/node/Observe.test.js
@@ -93,6 +93,31 @@ describe('Observe.test.js', () => {
                 });
             });
         });
+        describe('.remove()', () => {
+            describe('positive', () => {
+                it('should fire on remove', async() => {
+                    const db = await RxDatabase.create(randomToken(10), memdown);
+                    const colName = randomToken(10);
+                    const c = await db.collection(colName, schemas.human);
+                    let ar = [];
+                    const sub = c
+                			.find()
+                			.$
+                			.subscribe(docs => ar.push(docs));
+
+                    await util.promiseWait(10);
+                    await c.insert(schemaObjects.human());
+                    await util.promiseWait(10);
+                    assert.equal(ar.length, 3);
+                    const doc = await c.findOne().exec();
+                    await doc.remove();
+                    await util.promiseWait(10);
+                    assert.equal(ar.length, 4);
+                    sub.unsubscribe();
+                    db.destroy();
+                });
+            });
+        });
     });
     describe('Document', () => {
         describe('.save()', () => {