Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the CI and tests from Deno 1.44.1 to Deno 2.0.6 #6739

Closed
jkinggg opened this issue Jan 7, 2025 · 3 comments
Closed

Update the CI and tests from Deno 1.44.1 to Deno 2.0.6 #6739

jkinggg opened this issue Jan 7, 2025 · 3 comments

Comments

@jkinggg
Copy link
Contributor

jkinggg commented Jan 7, 2025

@pubkey I would like to claim this task: Update the CI and tests from Deno 1.44.1 to Deno 2.0.6

I'm planning to update the following:

  • Update Deno version
  • Update depreciated and new Deno flags
  • Update module import statements (i.e. assert)
  • Update isDeno statement

I will ensure compatibility with the following test runs:

  • deno:dexie
  • deno:denokv
  • deno:memory

This should only take me a day to complete.

Note: 1 test is failing on Deno 1.46.3 for dexie and denokv

@jkinggg
Copy link
Contributor Author

jkinggg commented Jan 7, 2025

@pubkey below are the results after the changes mentioned above. Both dexie and memory are now passing. I will create a PR shortly. Denokv is failing. Any thoughts on why? I can dig in deeper tomorrow.

1 failing

  1. internal-indexes.test.js
    usage
    should pick up the intenral index in the query planner:
    TypeError: database is locked
    at doAtomicWriteInPlace (ext:deno_kv/01_db.ts:629:10)
    at AtomicOperation.commit (ext:deno_kv/01_db.ts:408:26)
    at _loop (src/plugins/storage-denokv/rx-storage-instance-denokv.ts:179:32)
    at RxStorageInstanceDenoKV.bulkWrite (src/plugins/storage-denokv/rx-storage-instance-denokv.ts:106:24)
    at Object.bulkWrite (src/rx-storage-helper.ts:594:33)
    at RxDatabaseBase.addCollections (src/rx-database.ts:360:31)
    at Module.createBySchema (src/plugins/test-utils/humans-collection.ts:70:25)
    at createCollectionWithInternalIndexes (test/unit/internal-indexes.test.ts:9:24)
    at Context. (test/unit/internal-indexes.test.ts:84:26)

@pubkey
Copy link
Owner

pubkey commented Jan 7, 2025

No idea, sorry.

jkinggg added a commit to jkinggg/rxdb that referenced this issue Jan 7, 2025
jkinggg added a commit to jkinggg/rxdb that referenced this issue Jan 7, 2025
jkinggg added a commit to jkinggg/rxdb that referenced this issue Jan 7, 2025
@jkinggg
Copy link
Contributor Author

jkinggg commented Jan 7, 2025

@pubkey adding this error to the list of retriable errors solved the issue. All tests are passing except the original that was failing.

Please review #6742 when you get a chance and let me know if any changes are needed.

jkinggg added a commit to jkinggg/rxdb that referenced this issue Jan 8, 2025
jkinggg added a commit to jkinggg/rxdb that referenced this issue Jan 8, 2025
@pubkey pubkey closed this as completed in ed9f346 Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants