Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes electron spectron test spec, #3022; #3115

Merged
merged 1 commit into from
May 5, 2021
Merged

fixes electron spectron test spec, #3022; #3115

merged 1 commit into from
May 5, 2021

Conversation

kukagg
Copy link
Contributor

@kukagg kukagg commented May 4, 2021

This PR contains:

  • A minor fix for Electron Spectron test that seemingly failed due to no delay

Describe the problem you have without this PR

  • Electron test must be fixed before other fixes can be merged

Todos

None

@pubkey pubkey merged commit 6fa2695 into pubkey:master May 5, 2021
@pubkey
Copy link
Owner

pubkey commented May 5, 2021

Thank you, merged.

@pubkey
Copy link
Owner

pubkey commented May 5, 2021

I activated the electron tests, but they still seem to randomly fail https://github.com/pubkey/rxdb/runs/2513495325

@kukagg
Copy link
Contributor Author

kukagg commented May 6, 2021

Thanks! Yeah, seems like it’s stuck for some reason. Was it the same for you locally? Is there a way to get artifacts out of the Github actions instance here? Not visible publicly for me. @pubkey

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants