Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Svelte example project #3287

Merged
merged 3 commits into from
Aug 18, 2021
Merged

Conversation

bkeating
Copy link
Contributor

This PR contains a base-bones Svelte project that demonstrates how to use RxDB by way of a simple note-taking application.

@pubkey
Copy link
Owner

pubkey commented Jul 21, 2021

Thank you.
We need to add the example to the CI to ensure it always works.
In the other examples we run some e2e tests via testcafe, maybe you can add this to the svelte example also. https://github.com/pubkey/rxdb/blob/master/examples/angular/test/e2e.test.js

@bkeating
Copy link
Contributor Author

Absolutely. Just thought I’d kick off a PR to pick up some momentum. Thank you for your quick reply and I’ll get working on the CI and e2e tests in-place.

@DominikGuzei
Copy link

I would suggest refactoring this example app to https://kit.svelte.dev/ as this would reduce the setup boilerplate code tremendously and will probably become the recommended way to write real-world Svelte apps.

@bkeating
Copy link
Contributor Author

bkeating commented Aug 5, 2021

Thank you for looking into this. A SvelteKit example would be great as well, but I made this for raw svelte on purpose. I’m making a few electron apps that utilize rxdb and that are written in svelte so this was the byproduct that i promised myself I’d share out. (:

@bkeating
Copy link
Contributor Author

Had a little time to look at this today. I don't have a test completed yet, but it looks straightforward. Svelte is a compiler, so if all these tests are going off element ids/classes, we should have no problem as it's all there and accessible. Eager to see what the result is. Im hoping the reactivity of it all shines through.

@bkeating
Copy link
Contributor Author

ok, @pubkey I just committed a basic e2e test. Now im itching to go test more things. Super cool framework.

Is there anything else I need to cover?

@pubkey pubkey merged commit e4b3298 into pubkey:master Aug 18, 2021
@pubkey
Copy link
Owner

pubkey commented Aug 18, 2021

I tested this locally and merged it. I will add it to the CI. Thank you very much for your work.

pubkey added a commit that referenced this pull request Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants