Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update graphql ws deps #3980

Merged
merged 4 commits into from
Sep 19, 2022
Merged

Update graphql ws deps #3980

merged 4 commits into from
Sep 19, 2022

Conversation

herefishyfish
Copy link
Contributor

This PR contains:

Removes deprecated subscriptions-transport-ws package and replaces it with the recommended graphql-ws package.

@pubkey I ran into a couple of issues.

  1. I was having some issues bumping the version of the isometric-ws package and have left that out of this PR
  2. The tests aren't running on Windows, well my machine anyway- I think they're correct...

"local-web-server": "5.2.1",
"normalize.css": "8.0.1",
"pouchdb-adapter-idb": "7.2.2",
"preinstall": "^0.0.1-security",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WTF?

This package contained malicious code and was removed from the registry by the npm security team. A placeholder was published to ensure users are not affected in the future.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WTF indeed....

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think your computer is compromised

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the package. Nuking PC....

@pubkey pubkey merged commit b9ccfe5 into pubkey:master Sep 19, 2022
@pubkey
Copy link
Owner

pubkey commented Sep 19, 2022

Thank you, merged.
I added it to the changelog here: bf6edcc
Release will come in a few minutes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants