Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in CRDT Plugin: RxDDcrdtPlugin #4094

Merged
merged 1 commit into from
Oct 28, 2022
Merged

Typo in CRDT Plugin: RxDDcrdtPlugin #4094

merged 1 commit into from
Oct 28, 2022

Conversation

jwallet
Copy link
Contributor

@jwallet jwallet commented Oct 28, 2022

This PR contains:

  • A BREAKING CHANGE, a plugin typo

Describe the problem you have without this PR

All plugin have RxDB as a prefix, CRDT plugin did not have it. Also, if you want to merge it, it will probably better to fix the lowercase crtd to all uppercase since its an abbreviation.

@pubkey pubkey merged commit a35bd92 into pubkey:master Oct 28, 2022
@pubkey
Copy link
Owner

pubkey commented Oct 28, 2022

Thank you, merged.
Having all uppercase is a problem with the generated error message when the plugin is missing.

pubkey added a commit that referenced this pull request Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants