Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP RxQuery.count() #4096

Merged
merged 19 commits into from
Oct 31, 2022
Merged

WIP RxQuery.count() #4096

merged 19 commits into from
Oct 31, 2022

Conversation

pubkey
Copy link
Owner

@pubkey pubkey commented Oct 30, 2022

This PR contains:

Describe the problem you have without this PR

Todos

  • Tests
  • Documentation
  • Typings
  • Changelog

@pubkey pubkey changed the title ADD RxQuery.count() step 1 WIP RxQuery.count() Oct 30, 2022
@pubkey pubkey mentioned this pull request Oct 31, 2022
@pubkey pubkey merged commit ffb7219 into master Oct 31, 2022
@kicohen2
Copy link

kicohen2 commented Feb 5, 2023

Just an FYI. This should have been included in a major version release. When upgrading from an earlier version of 13 to 13.17, our application won't open anything from RXDB since we have implemented our own count method on almost all of our collections. Since count was added it is now a protected keyword and the application throws on the ORM checks.

rx-error.ts:107 Uncaught (in promise) RxError (COL17): RxError (COL17):
RxCollection.ORM: statics-name not allowed
Given parameters: {
name:"count"}
    at newRxError (rx-error.ts:107:12)
    at check-orm.ts:42:23
    at Array.forEach (<anonymous>)
    at checkOrmMethods (check-orm.ts:18:10)
    at after5 (index.ts:109:17)
    at hooks.ts:86:35
    at Array.forEach (<anonymous>)
    at runPluginHooks (hooks.ts:86:20)
    at rx-collection.ts:1108:17

Super handy feature that we are appreciative for but just asking that we be a little more careful with backwards incompatible changes.

@pubkey
Copy link
Owner Author

pubkey commented Feb 5, 2023

@kicohen2 yes you are right, sorry for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants