Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: active$ should emit during replication #4117

Closed
wants to merge 1 commit into from
Closed

test: active$ should emit during replication #4117

wants to merge 1 commit into from

Conversation

maxnowack
Copy link
Contributor

This PR contains:

  • IMPROVED TESTS

Describe the problem you have without this PR

It seems that the behavior of replicationState.active$ has changed since v13. In v12, replicationState.active$ emits when replication is running.
I could not find out when replicationState.active$ emits in v13. It may not be emitted at all.
This PR only contains a test that fails if replicationState.active$ has not emitted true during the initial replication.
I have not provided a bugfix, because I don't yet understand the correlations in the code regarding the replication well enough.

pubkey added a commit that referenced this pull request Nov 10, 2022
@pubkey pubkey mentioned this pull request Nov 10, 2022
@pubkey pubkey closed this in 12cee0a Nov 10, 2022
@pubkey
Copy link
Owner

pubkey commented Nov 10, 2022

Fixed here #4124

@maxnowack maxnowack deleted the replication-emit-active branch November 10, 2022 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants