Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test and fix for crash with null in selector #4369

Merged
merged 1 commit into from
Jan 31, 2023
Merged

Test and fix for crash with null in selector #4369

merged 1 commit into from
Jan 31, 2023

Conversation

swnf
Copy link
Contributor

@swnf swnf commented Jan 31, 2023

This PR contains:

  • IMPROVED TESTS
  • A BUGFIX

Describe the problem you have without this PR

If I use null in the selector RxDB crashes in this line:

rxdb/src/rx-query-helper.ts

Line 172 in b24d101

const keys = Object.keys(selector);

@pubkey pubkey merged commit b0fb1fb into pubkey:master Jan 31, 2023
pubkey added a commit that referenced this pull request Jan 31, 2023
@pubkey
ADD(changelog) #4369
965491e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@swnf @pubkey