Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: query-builder copies RxQuery's other param #4586 #4587

Merged
merged 1 commit into from
Mar 23, 2023
Merged

fix: query-builder copies RxQuery's other param #4586 #4587

merged 1 commit into from
Mar 23, 2023

Conversation

darkowic
Copy link
Contributor

This PR contains:

Fixes #4586

Decided to not create the helper because it would still require manual copying of other. I realized that other is actually quite important for caching, as it is used in toString method which is used in tunnelQueryCache.

@pubkey pubkey merged commit 343ecba into pubkey:master Mar 23, 2023
pubkey added a commit that referenced this pull request Mar 23, 2023
@pubkey
ADD(changelog) #4587
044cce9
@darkowic darkowic deleted the 4586-clone-query branch March 24, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Query builder plugin is not copying RxQuery other property
2 participants
@darkowic @pubkey