Add mutable whitelist contract and package #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tasiov
reviewed
Jun 6, 2023
| use crate::msg::InstantiateMsg; | ||
| use crate::state::{Config, CONFIG, WHITELIST}; | ||
|
|
||
| const CONTRACT_NAME: &str = "crates.io:stargaze-whitelist-mutable"; |
There was a problem hiding this comment.
should we rename to stargaze-mutable-whitelist to match
| WHITELIST.count(deps.storage) | ||
| } | ||
|
|
||
| pub fn query_list(deps: Deps) -> StdResult<Vec<String>> { |
There was a problem hiding this comment.
i guess we need to add pagination here
|
We need to add unit tests |
tasiov
reviewed
Jun 6, 2023
| @@ -0,0 +1,2 @@ | |||
| // re-export the proc macros | |||
| pub use sg_basic_whitelist_derive::sg_basic_whitelist_query; | |||
There was a problem hiding this comment.
i havn't seen this before, where there a nested Cargo.toml packages within a workspace, maybe we put the macro Cargo.toml up one level?
Remove `sg-mutable-whitelist` package
|
TODO: Implement the interface from cw1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primitives for whitelists. This introduces packages for the most basic whitelist types as well as a mutable whitelist contract. These will be built on top of for Launchpad's wave mints.
Also introduces the
sg_basic_whitelist_querymacro to make the whitelist query interface typesafe.Note: CI tests, schema and type generation will come in a future PR.