dYdX Airdrop updates #652
Merged
dYdX Airdrop updates #652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cosm-Orc Gas Usage
Raw Report for 5f1ed3e
|
| Ok(res) | ||
| } | ||
|
|
||
| pub fn dust_and_whitelist_add( |
There was a problem hiding this comment.
I think this can just be whitelist_add and call the dust( ) function from the calling function
| @@ -19,158 +15,21 @@ pub fn claim_airdrop( | |||
| eth_sig: String, | |||
| ) -> Result<Response, ContractError> { | |||
| let config = CONFIG.load(deps.storage)?; | |||
| let airdrop_count_limit = config.airdrop_count_limit; | |||
| if AIRDROP_COUNT.load(deps.storage)? >= airdrop_count_limit { | |||
There was a problem hiding this comment.
This can be a one line assert check
| Ok(()) | ||
| } | ||
|
|
||
| pub fn check_previous_claim(deps: &DepsMut, eth_address: &str) -> Result<(), ContractError> { |
There was a problem hiding this comment.
Shouldn't a "previous claim" just be the address to mint count matches the max airdrop amount or do we need to track something different?
There was a problem hiding this comment.
Only the reward is being claimed currently. Not tracking a mint count. The user is expected to mint the token outside of the airdrop contract through the regular minting process.
| @@ -37,6 +37,7 @@ fn query_minter_as_expected(app: &mut StargazeApp, airdrop_contract: Addr, minte | |||
| fn test_instantiate() { | |||
| let mut app = custom_mock_app(); | |||
| let minter_address = Addr::unchecked("contract1"); | |||
| let name_discount_wl_address = Addr::unchecked(MOCK_NAME_DISCOUNT_WL_ADDR_STR); | |||
There was a problem hiding this comment.
I think we need some new unit tests that test the additional functionality, such as can only do the claim after name is registered correct?
There was a problem hiding this comment.
Correct. Updating them currently.
…updates dydx airdrop updates
jhernandezb
merged commit 4744ccb
into
humanalgorithm/dydx-main-branch-v3.x
14 of 20 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.