-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add whitelist-immutable-flex #660
Add whitelist-immutable-flex #660
Conversation
Cosm-Orc Gas Usage
Raw Report for 553d7b0
|
Ok(includes) | ||
} | ||
|
||
pub fn address_count(&self, querier: &QuerierWrapper) -> StdResult<u64> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there address count or is this mint count for address? I think the second name makes more sense?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a separate Member query that returns the mint count for each address. AddressCount is legacy and returns the total number of members.
pub mint_discount_bps: Option<u64>, | ||
} | ||
|
||
impl Config { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need a whitelist wide discount bps?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's an optional parameter and we can remove it, but my intention was not to take away from the original contract in case it's used again for its initial purpose but with a mint_count
for each address.
…list-immutable-flex
1f70709
into
humanalgorithm/dydx-main-branch-v3.x
No description provided.