Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add whitelist-immutable-flex #660

Conversation

MightOfOaks
Copy link
Member

No description provided.

Copy link

github-actions bot commented Feb 22, 2024

Cosm-Orc Gas Usage

Contract Op Name Gas Used Old Gas Used Gas Diff File
vending_factory Store__Store 3408347 3082476 +10.5717% e2e/src/helpers/chain.rs:78
open_edition_factory Store__Store 3813089 3506900 +8.7310% e2e/src/helpers/chain.rs:78
base_factory Store__Store 2989591 2696792 +10.8573% e2e/src/helpers/chain.rs:78
base_minter Store__Store 7166934 7068056 +1.3989% e2e/src/helpers/chain.rs:78
open_edition_minter Store__Store 8826066 8700070 +1.4482% e2e/src/helpers/chain.rs:78
sg721_base Store__Store 8525902 8416494 +1.2999% e2e/src/helpers/chain.rs:78
sg721_metadata_onchain Store__Store 8983749 8886444 +1.0950% e2e/src/helpers/chain.rs:78
sg721_nt Store__Store 7947246 7842375 +1.3372% e2e/src/helpers/chain.rs:78
sg721_updatable Store__Store 9332175 9204723 +1.3846% e2e/src/helpers/chain.rs:78
sg_whitelist Store__Store 3711208 3599317 +3.1087% e2e/src/helpers/chain.rs:78
sg_whitelist_flex Store__Store 3648262 3528506 +3.3940% e2e/src/helpers/chain.rs:78
vending_minter Store__Store 9022424 8892840 +1.4572% e2e/src/helpers/chain.rs:78
vending_minter_merkle_wl Store__Store 9270919 9138800 +1.4457% e2e/src/helpers/chain.rs:78
vending_minter_wl_flex Store__Store 9202084 9075906 +1.3903% e2e/src/helpers/chain.rs:78
whitelist_immutable Store__Store 2271029 2206354 +2.9313% e2e/src/helpers/chain.rs:78
whitelist_mtree Store__Store 7154909 7025364 +1.8440% e2e/src/helpers/chain.rs:78
Raw Report for 553d7b0
Contract Op Name Gas Used Gas Wanted File
vending_factory Instantiate__factory_inst 187385 257960 e2e/src/helpers/helper.rs:35
vending_factory Execute__factory_exec_minter_inst 34037887 51033638 e2e/src/tests/factory_test.rs:98
vending_factory Execute__factory_exec_minter_inst_w_trading_time 3858653 5764779 e2e/src/tests/factory_test.rs:244
vending_factory Store__Store 3408347 5089380 e2e/src/helpers/chain.rs:78
multiple_contracts Execute__minter_batch_exec_mint_token_w_trading_time 1953393 2900783 e2e/src/tests/factory_test.rs:314
multiple_contracts Execute__minter_batch_exec_mint_token 3158368 4714691 e2e/src/tests/open_edition_factory_and_mint_tests.rs:276
open_edition_factory Execute__factory_exec_minter_inst_w_trading_time 548183 799151 e2e/src/tests/open_edition_factory_and_mint_tests.rs:411
open_edition_factory Instantiate__factory_inst 188168 259134 e2e/src/helpers/open_edition_minter_helpers.rs:39
open_edition_factory Execute__factory_exec_minter_inst 547472 798083 e2e/src/tests/open_edition_factory_and_mint_tests.rs:206
open_edition_factory Store__Store 3813089 5696493 e2e/src/helpers/chain.rs:78
minter Execute__minter_exec_mint_to_token 365552 525204 e2e/src/tests/open_edition_minter_executes_tests.rs:181
minter Execute__minter_exec_purge 140239 187293 e2e/src/tests/open_edition_minter_executes_tests.rs:282
minter Execute__minter_exec_update_per_addr_limit 209878 291699 e2e/src/tests/open_edition_minter_executes_tests.rs:217
minter Execute__minter_exec_update_trading_time 271494 384122 e2e/src/tests/open_edition_minter_executes_tests.rs:100
base_factory Store__Store 2989591 4461246 e2e/src/helpers/chain.rs:78
base_minter Store__Store 7166934 10727201 e2e/src/helpers/chain.rs:78
open_edition_minter Store__Store 8826066 13215894 e2e/src/helpers/chain.rs:78
sg721_base Store__Store 8525902 12765653 e2e/src/helpers/chain.rs:78
sg721_metadata_onchain Store__Store 8983749 13452423 e2e/src/helpers/chain.rs:78
sg721_nt Store__Store 7947246 11897669 e2e/src/helpers/chain.rs:78
sg721_updatable Store__Store 9332175 13975062 e2e/src/helpers/chain.rs:78
sg_whitelist Store__Store 3711208 5543672 e2e/src/helpers/chain.rs:78
sg_whitelist_flex Store__Store 3648262 5449253 e2e/src/helpers/chain.rs:78
vending_minter Store__Store 9022424 13510436 e2e/src/helpers/chain.rs:78
vending_minter_featured Store__Store 9105780 13635470 e2e/src/helpers/chain.rs:78
vending_minter_merkle_wl Store__Store 9270919 13883178 e2e/src/helpers/chain.rs:78
vending_minter_wl_flex Store__Store 9202084 13779926 e2e/src/helpers/chain.rs:78
vending_minter_wl_flex_featured Store__Store 9119469 13656003 e2e/src/helpers/chain.rs:78
whitelist_immutable Store__Store 2271029 3383403 e2e/src/helpers/chain.rs:78
whitelist_immutable_flex Store__Store 2268026 3378899 e2e/src/helpers/chain.rs:78
whitelist_mtree Store__Store 7154909 10709163 e2e/src/helpers/chain.rs:78

Ok(includes)
}

pub fn address_count(&self, querier: &QuerierWrapper) -> StdResult<u64> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there address count or is this mint count for address? I think the second name makes more sense?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a separate Member query that returns the mint count for each address. AddressCount is legacy and returns the total number of members.

pub mint_discount_bps: Option<u64>,
}

impl Config {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need a whitelist wide discount bps?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's an optional parameter and we can remove it, but my intention was not to take away from the original contract in case it's used again for its initial purpose but with a mint_count for each address.

@MightOfOaks MightOfOaks merged commit 1f70709 into humanalgorithm/dydx-main-branch-v3.x Mar 3, 2024
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants