Skip to content

Commit

Permalink
Merge pull request #5 from pubref/disable_sha256
Browse files Browse the repository at this point in the history
Disable sha256 in WORKSPACE until less flaky
  • Loading branch information
pcj authored Jan 22, 2017
2 parents d76e649 + d4ccbed commit c63bbcc
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 6 deletions.
4 changes: 3 additions & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,9 @@ os:
- osx

env:
- V=HEAD
- V=0.4.3
- V=0.4.2
- V=0.4.1
- V=0.4.0
- V=0.3.2
- V=0.3.1
Expand Down
4 changes: 4 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,10 @@ you can determine this). By setting a `sha256`, you can guard against
the code changing, but you are not guarding against a malicious
attacker sneaking in bogus code in the first place.

> Note: the `WORKSPACE` for `rules_node` itself is not yet using the
> sha256 option as there seems to be remaining non-determinism that
> renders it flaky.
#### What gets removed before determining the sha256?

In order to make npm deterministic it is necessary to:
Expand Down
10 changes: 5 additions & 5 deletions WORKSPACE
Original file line number Diff line number Diff line change
Expand Up @@ -17,37 +17,37 @@ npm_repository(
"react": "15.3.2",
"react-dom": "15.3.2",
},
sha256 = "fa7f0306841e8f03de78bd4b80f0da525238cf95cb360d7072013ca5fe7215e0",
#sha256 = "fa7f0306841e8f03de78bd4b80f0da525238cf95cb360d7072013ca5fe7215e0",
)

npm_repository(
name = "npm_mocha",
deps = {
"mocha": "3.1.0",
},
sha256 = "9b48987065bb42003bab81b4538afa9ac194d217d8e2e770a5cba782249f7dc8",
#sha256 = "9b48987065bb42003bab81b4538afa9ac194d217d8e2e770a5cba782249f7dc8",
)

npm_repository(
name = "npm_underscore",
deps = {
"underscore": "1.8.3",
},
sha256 = "7c413345ad4f97024258e5d9fda40e26be0f2c2b73987d13f03352b5c489b1a8",
#sha256 = "7c413345ad4f97024258e5d9fda40e26be0f2c2b73987d13f03352b5c489b1a8",
)

npm_repository(
name = "npm_bower",
deps = {
"bower": "1.7.9",
},
sha256 = "7f85a05c00a86b0f9cfd8d58ad61d0447bd9235d13a743ede87af1ca5509403f",
#sha256 = "7f85a05c00a86b0f9cfd8d58ad61d0447bd9235d13a743ede87af1ca5509403f",
)

bower_repository(
name = "bower_react_stack",
deps = {
"react": "15.3.2",
},
sha256 = "9779fcd247213b898d53473d4cc884f8b2d64b7d8021f56dd54a6dcd5f1bf845",
#sha256 = "9779fcd247213b898d53473d4cc884f8b2d64b7d8021f56dd54a6dcd5f1bf845",
)

0 comments on commit c63bbcc

Please sign in to comment.