Fix 500 error when using flatpak with reclaimed content [PULP-262] #1899
+125
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gerrod3
force-pushed
the
flatpak-ondemand
branch
from
4191a87 to
38bed1a
Compare
gerrod3
force-pushed
the
flatpak-ondemand
branch
from
38bed1a to
d0fafa7
Compare
ianballou
reviewed
Jan 21, 2025
gerrod3
changed the title
git-hyagi
approved these changes
Jan 22, 2025
Backport to 2.22: 💚 backport PR created✅ Backport PR branch: Backported as #1900 🤖 @patchback |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After looking through the history and current state of the Manifest model I came up with this solution to try to get the metadata off the model if it is there and then fallback to the config blob. If the config blob is not there during a fallback then the image will be skipped from the returned results of the index call. This bugfix can only really be back ported to 0.22 since it relies on the new manifest fields. Flatpak index was added in 0.16, so a different solution would be needed to be backported for these inbetween releases. Thoughts on whether I should create these other backports?
fixes: #1887