Fix yaml parsing #110
Merged
Fix yaml parsing #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EronWright
requested changes
Dec 2, 2023
rquitales
force-pushed
the
rquitales/fix-yaml-parsing
branch
from
e3310f2 to
c9f0ce4
Compare
new cilium example (cherry picked from commit 6b52469)
rquitales
force-pushed
the
rquitales/fix-yaml-parsing
branch
from
c9f0ce4 to
f29ebda
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a stacked PR on top of #107 (the last 3 commits are the new additions) that modifies how we interact with yaml strings in our AST parsing. Instead of using the
String()method on nodes, which requires mutating the nodes to handle comments properly, this PR updates our codebase to use theValuemethod of the ast nodes instead. This gives us better output with correct formatting, eg. correct handling of octal values of file permissions and better multiline string formatting.Fixes: #109
Fixes #112
Fixes: #115