Clean up after addons were introduced #1369
Assignees
Labels
Comments
|
Added to epic https://github.com/pulumi/home/issues/3558 |
flostadler
added
kind/engineering
This was referenced Sep 18, 2024
flostadler
added a commit
that referenced
this issue
Sep 20, 2024
Now that the EKS addons are added we need to align them and do some cleanup. This involves: - adding the enums introduced in #1357 to the VPC CNI - exposing configurationValues for coredns and kube-proxy - removing kubectl from the provider - deeply sort addon configuration keys to guarantee stable json serialization - remove deepmerge again. It caused issues during unit tests (voodoocreation/ts-deepmerge#22) and when used on outputs. Additionally I discovered and fixed an old bug that luckily never surfaced. The VPC CNI configuration did incorrectly handle outputs and called `toString` on them in a couple of places. The increased type safety and tests around addon configuration uncovered this. Closes #1369
|
Cannot close issue:
Please fix these problems and try again. |
flostadler
added a commit
that referenced
this issue
Oct 17, 2024
Now that the EKS addons are added we need to align them and do some cleanup. This involves: - adding the enums introduced in #1357 to the VPC CNI - exposing configurationValues for coredns and kube-proxy - removing kubectl from the provider - deeply sort addon configuration keys to guarantee stable json serialization - remove deepmerge again. It caused issues during unit tests (voodoocreation/ts-deepmerge#22) and when used on outputs. Additionally I discovered and fixed an old bug that luckily never surfaced. The VPC CNI configuration did incorrectly handle outputs and called `toString` on them in a couple of places. The increased type safety and tests around addon configuration uncovered this. Closes #1369
flostadler
added a commit
that referenced
this issue
Oct 17, 2024
Now that the EKS addons are added we need to align them and do some cleanup. This involves: - adding the enums introduced in #1357 to the VPC CNI - exposing configurationValues for coredns and kube-proxy - removing kubectl from the provider - deeply sort addon configuration keys to guarantee stable json serialization - remove deepmerge again. It caused issues during unit tests (voodoocreation/ts-deepmerge#22) and when used on outputs. Additionally I discovered and fixed an old bug that luckily never surfaced. The VPC CNI configuration did incorrectly handle outputs and called `toString` on them in a couple of places. The increased type safety and tests around addon configuration uncovered this. Closes #1369
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Once the addons for vpc-cni, coredns and kube-proxy are added we need to do some cleanup.
This involves:
kube-proxyandcoredns#1357 to the VPC CNIconfigurationValuesfor coredns and kube-proxyThe text was updated successfully, but these errors were encountered: