Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider default lowercasing all names when autonaming resources in GCP #2164

Open
VenelinMartinov opened this issue Jul 8, 2024 · 0 comments
Open

Consider default lowercasing all names when autonaming resources in GCP #2164

VenelinMartinov opened this issue Jul 8, 2024 · 0 comments
Labels
kind/enhancement Improvements or new features

Comments

@VenelinMartinov
Copy link
Contributor

Describe what happened

A lot of resources don't accept capital letters in their names, failing during creating.

We should consider lowercasing all of them. This will need a bit of work in the bridge I believe.

Sample program

#2162

Log output

.

Affected Resource(s)

No response

Output of pulumi about

.

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).
@VenelinMartinov VenelinMartinov added kind/engineering Work that is not visible to an external user kind/enhancement Improvements or new features and removed kind/engineering Work that is not visible to an external user labels Jul 8, 2024
@VenelinMartinov VenelinMartinov mentioned this issue Jul 8, 2024
Merged
VenelinMartinov added a commit that referenced this issue Jul 8, 2024
@VenelinMartinov
Fix cloudrun service auto name (#2163)
50657a0 
fixes #2162

Cloudrun service, like a bunch of other resources in GCP does not accept
capital letters in its name. This fixes the autonaming to lowercase the
pulumi name.

Opened #2164 to follow up on
defaulting this for all resources in GCP.
This was referenced Jul 11, 2024
Closed
Merged
VenelinMartinov added a commit that referenced this issue Aug 20, 2024
@VenelinMartinov
Fix firestore database autoname (#2184)
53168e9 
fixes #2183

Firestore database needs an all lowercase name since the API errors
otherwise.

We should likely do this for all GCP resources as it looks like quite a
few of them have this: #2164
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement Improvements or new features
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@VenelinMartinov