Implement notifications configuration for .travis.yml

[nmaludy]

Closes #119

This PR implements an override in .travis.yml for the notifications section so repos can send notifications to things like Slack.

[ardrigh]

I have need for similar functions. It would be nice if these PRs could be reviewed.

[scotje]

Thanks for the PR @nmaludy !

I added a couple of stylistic suggestions but feel free to provide rationale for the current choices if you feel they are merited.

[scotje]

Does this need to guard against @configs['notifications'] possibly being nil? I realize it has a default, but someone maybe could override it to nil?

[scotje]

Was there a situation where this value was not an array but could be safely coerced into an array? If not, we can just drop to:

Suggested change

	<% notifications_arr = ((@configs['notifications'].to_a || []) - (@configs['remove_notifications'].to_a || [])) -%>
	<% notifications_arr = ((@configs['notifications'] || []) - (@configs['remove_notifications'] || [])) -%>

[nmaludy]

@scotje Notifications is a hash, but in order to provide a "difference" between the @config['notifications'] and @config['remove_notifications'] i converted to an array to make this difference logic easier.

[ardrigh]

I think this code creates a bug in .travis.yml if you need to set email: false.

In .sync.yml this adds the slack channel notification and removes email:false in .travis.yml

  notifications:
    - slack:
        secure: BLAHBLAHBLAHBLAHBLAHBLAH

I tried a few variations of notifications but none of them add email:false as expected.

Any ideas?

[scotje]

@ardrigh I was able to configure both email: false and a slack notification with the following in my .sync.yml:

notifications:
  email: false
  slack:
    secure: foozle

and running pdk update. Does that config work for you? If not, could you open a new issue here or on the puppetlabs/pdk project?

[ardrigh]

@scotje sorry I haven't tested this for a while.

I just tried PDK 1.9.1 and I have the format working now, so it's not trying to remove the secure notification for Slack any longer.