Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improved README wording #246

Merged
merged 4 commits into from
Jun 26, 2019
Merged

improved README wording #246

merged 4 commits into from
Jun 26, 2019

Conversation

rtib
Copy link
Contributor

@rtib rtib commented May 2, 2019

A proposal to #159

scotje
scotje previously approved these changes Jun 25, 2019
View reviewed changes
Copy link
Contributor

@scotje scotje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @rtib!

@scotje
Copy link
Contributor

scotje commented Jun 25, 2019

I will rebase.

@scotje scotje added this to the PDK 1.11.0.0 milestone Jun 25, 2019
scotje
scotje approved these changes Jun 25, 2019
View reviewed changes
Copy link
Contributor

@scotje scotje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to confirm, after #172 people won't need to customize the bundler_args in .travis.yml anymore?

@rodjek rodjek merged commit 67637d4 into puppetlabs:master Jun 26, 2019
@rtib
Copy link
Contributor Author

rtib commented Jun 27, 2019

#172 was a great improvement, wasn't it? Glad to got it successful. 😤

@rtib rtib deleted the gh_159 branch June 27, 2019 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scotje scotje scotje approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
PDK 1.11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@rtib @scotje @rodjek