Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GitLab CI empty custom job parameter handling #276

Merged
merged 1 commit into from
Sep 24, 2019

Conversation

seanmil
Copy link
Contributor

@seanmil seanmil commented Sep 6, 2019

When generating GitLab CI configuration containing custom jobs
with parameters consisting of empty arrays or hashes, correctly
generate the .gitlab-ci.yml with those empty types.

When generating GitLab CI configuration containing custom jobs
with parameters consisting of empty arrays or hashes, correctly
generate the .gitlab-ci.yml with those empty types.
@scotje scotje added this to the September 2019 milestone Sep 24, 2019
Copy link
Contributor

@scotje scotje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @seanmil !

@scotje scotje merged commit 50736c8 into puppetlabs:master Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants