Changes for github_changelog_generator Raketask #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added github_site for remote server - Added github_endpoint for remote server - Added gitlab for preparation of gitlab support added in (github-changelog-generator/github-changelog-generator#657) These settings will not be added by default. Only if added to .sync.yml They allow for GitHub Enterprise and Gitlab options down the road.
scotje
reviewed
Jan 30, 2020
glennsarti
reviewed
Jan 31, 2020
cdenneen
force-pushed
the
alternate_github
branch
from
774545b to
1eeb4ee
Compare
|
@scotje @glennsarti can you please re-approve. I messed up and ended up having to force-push |
scotje
approved these changes
Feb 3, 2020
glennsarti
reviewed
Feb 4, 2020
| @@ -77,6 +77,15 @@ PuppetLint.configuration.send('<%= option %>') | |||
| if Bundler.rubygems.find_name('github_changelog_generator').any? | |||
| GitHubChangelogGenerator::RakeTask.new :changelog do |config| | |||
| raise "Set CHANGELOG_GITHUB_TOKEN environment variable eg 'export CHANGELOG_GITHUB_TOKEN=valid_token_here'" if Rake.application.top_level_tasks.include? "changelog" and ENV['CHANGELOG_GITHUB_TOKEN'].nil? | |||
| <% if @configs['github_site'] -%> | |||
| config.github_site = <%= @configs['github_site'].inspect %> | |||
There was a problem hiding this comment.
Without tests this could be interesting. .inspect has bitten us before with YAML files. But as this is a ruby file and inspect generates ruby code, this is probably safe (?)
glennsarti
approved these changes
Feb 4, 2020
glennsarti
approved these changes
Feb 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These settings will not be added by default. Only if added to
.sync.ymlThey allow for GitHub Enterprise and Gitlab options down the road.