Disable RuboCop Style/BracesAroundHashParameters #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sharpie
force-pushed
the
disable-rubocop-BracesAroundHashParameters
branch
from
fff7a10 to
2c076db
Compare
Sharpie
commented
May 4, 2020
| @@ -159,6 +159,10 @@ Rakefile: | |||
| Description: Prefer braces for chaining. Mostly an aesthetical choice. Better to be consistent then. | |||
| EnforcedStyle: braces_for_chaining | |||
|
|
|||
| Style/BracesAroundHashParameters: | |||
| Description: Braces are required by Ruby 2.7. Cop removed from RuboCop v0.80.0: https://github.com/rubocop-hq/rubocop/pull/7643 | |||
| Enabled: false | |||
There was a problem hiding this comment.
This is repetitive, but it seems good to have a "Description" that tells people why this one is disabled. Open to arguments against it though.
The `Style/BracesAroundHashParameters` cop would flag "redundant" uses of braces to create hashes in Ruby method arguments. Ruby 2.7 requires these braces to disambiguate hash literals from keyword arguments and will issue warnings. The cop has been removed from RuboCop v0.80.0. See: https://www.ruby-lang.org/en/news/2019/12/12/separation-of-positional-and-keyword-arguments-in-ruby-3-0/ See: rubocop/rubocop#7643
Sharpie
force-pushed
the
disable-rubocop-BracesAroundHashParameters
branch
from
2c076db to
7e56045
Compare
|
Created https://tickets.puppetlabs.com/browse/IAC-778 to track this. |
DavidS
approved these changes
May 5, 2020
This was referenced Aug 10, 2020
alexjfisher
added a commit
to alexjfisher/pdk-templates
that referenced
this pull request
Aug 10, 2020
Despite puppetlabs#329 (which aimed to disable this cop), in the last round of module updates, it is set as `enabled: true` in all puppetlabs modules. Removing the line from the cleanup_cops seems to fix this.
alexjfisher
reviewed
Aug 10, 2020
| @@ -223,7 +223,6 @@ | |||
| - Style/BeginBlock | |||
| - Style/BlockComments | |||
| - Style/BlockDelimiters | |||
| - Style/BracesAroundHashParameters | |||
There was a problem hiding this comment.
This was not enough to stop the cop being enabled everywhere. See #344
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Style/BracesAroundHashParameterscop would flag "redundant" usesof braces to create hashes in Ruby method arguments. Ruby 2.7 requires
these braces to disambiguate hash literals from keyword arguments and
will issue warnings. The cop has been removed from RuboCop v0.80.0.
See: https://www.ruby-lang.org/en/news/2019/12/12/separation-of-positional-and-keyword-arguments-in-ruby-3-0/
See: rubocop/rubocop#7643