Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that the devcontainer.json is valid JSON #490

Merged
merged 1 commit into from
Jan 26, 2023

Conversation

zigsphere
Copy link
Contributor

Currently, the devcontainer.json template file is invalid JSON resulting in a failed JSON parser error if people have a JSON parser in their CI/CD pipeline. Fixing this to avoid this issue moving forward when updating or creating a module with PDK.

@zigsphere zigsphere requested a review from a team as a code owner January 26, 2023 17:49
@CLAassistant
Copy link

CLAassistant commented Jan 26, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

@chelnak chelnak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks!

@chelnak chelnak merged commit 383f471 into puppetlabs:main Jan 26, 2023
@chelnak chelnak added the bug label Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants