Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a remove_includes configuration option #67

Merged

Conversation

npwalker
Copy link
Contributor

@npwalker npwalker commented May 1, 2018

Prior to this commit, the user could not remove the default included checks
with configuration.

After this commit, the user can specify default checks that should be removed
in the remove_includes configuration setting in .sync.yml

This allows for a .sync.yml like the following that replaces check=spec with
check=parallel_spec.

.travis.yml:
  remove_includes:
    - env: CHECK=spec
    - env: PUPPET_GEM_VERSION="~> 4.0" CHECK=spec
      rvm:  2.1.9
  includes:
    - env: CHECK=parallel_spec
    - env: PUPPET_GEM_VERSION="= 4.6.1" CHECK=parallel_spec
      rvm: 2.1.9
    - env: PUPPET_GEM_VERSION="~> 4.0" CHECK=parallel_spec
      rvm: 2.1.9

@bmjen
Copy link
Contributor

bmjen commented May 14, 2018

@npwalker can you add a row to the .travis.yml section in the README with the new setting?

Copy link
Contributor

@bmjen bmjen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a docs update adding remove_includes to the README.

Prior to this commit, the user could not remove the default included checks
with configuration.

After this commit, the user can specify default checks that should be removed
in the remove_includes configuration setting in .sync.yml

This allows for a .sync.yml like the following that replaces check=spec with
check=parallel_spec.

```
.travis.yml:
  remove_includes:
    - env: CHECK=spec
    - env: PUPPET_GEM_VERSION="~> 4.0" CHECK=spec
      rvm:  2.1.9
  includes:
    - env: CHECK=parallel_spec
    - env: PUPPET_GEM_VERSION="= 4.6.1" CHECK=parallel_spec
      rvm: 2.1.9
    - env: PUPPET_GEM_VERSION="~> 4.0" CHECK=parallel_spec
      rvm: 2.1.9
```
@npwalker npwalker force-pushed the add_remove_includes_configuration_option branch from 8b34c35 to 9d8f17e Compare May 14, 2018 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants