Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PDK-681) Remove puppet-blacksmith #79

Merged
merged 1 commit into from
Jun 1, 2018
Merged

Conversation

DavidS
Copy link
Contributor

@DavidS DavidS commented May 8, 2018

As of puppetlabs/puppet-module-gems#65 puppet-blacksmith is carried in the puppet-module-gems, and does not need to be referenced here. This allows PDK users to override the pin with their own requirements.

@DavidS
Copy link
Contributor Author

DavidS commented May 8, 2018

This must not be merged before puppetlabs/puppet-module-gems#65 is released

@DavidS DavidS changed the title (PDK-681) Remove puppet-blacksmith [DO NOT MERGE] (PDK-681) Remove puppet-blacksmith May 8, 2018
@dhollinger
Copy link
Contributor

@DavidS @bmjen - are there any updates to the status of this?

As of puppetlabs/puppet-module-gems#65 puppet-blacksmith is carried in the puppet-module-gems, and does not need to be referenced here. This allows PDK users to override the pin with their own requirements.
@DavidS DavidS force-pushed the pdk-681-move-puppet-blacksmith branch from 8e22464 to f81acbc Compare June 1, 2018 08:49
@DavidS
Copy link
Contributor Author

DavidS commented Jun 1, 2018

I've rebased this to refresh the commit and trigger travis. the puppet-module-gem change has been merged, but not released.

@DavidS DavidS requested a review from bmjen June 1, 2018 08:50
@bmjen bmjen changed the title [DO NOT MERGE] (PDK-681) Remove puppet-blacksmith (PDK-681) Remove puppet-blacksmith Jun 1, 2018
@bmjen
Copy link
Contributor

bmjen commented Jun 1, 2018

puppet-blacksmith was added to version 0.3.3 of the puppet-module-gems.

@bmjen bmjen merged commit 6654f6d into master Jun 1, 2018
@bmjen bmjen deleted the pdk-681-move-puppet-blacksmith branch June 1, 2018 20:57
@DavidS
Copy link
Contributor Author

DavidS commented Jun 4, 2018

Worked for me:

$ pdk bundle list puppet-blacksmith
pdk (INFO): Using Ruby 2.4.4
pdk (INFO): Using Puppet 5.5.1
/home/david/.pdk/cache/ruby/2.4.0/gems/puppet-blacksmith-4.1.2

$ pdk --version
1.6.0.pre (43)
$ grep template- metadata.json 
  "template-url": "https://github.com/puppetlabs/pdk-templates.git",
  "template-ref": "heads/master-0-g6654f6d"
$ 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants