(CONT-935) Additional RuboCop fixes

puppetlabs · May 25, 2023 · 6584844 · 6584844
1 parent b9dfa0c
commit 6584844
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/lib/pdk/cli/exec/interactive_command.rb b/lib/pdk/cli/exec/interactive_command.rb
@@ -4,6 +4,7 @@ module PDK
   module CLI
     module Exec
       class InteractiveCommand < Command
+        # rubocop :disable Lint/MissingSuper
         def initialize(*argv)
           @argv = argv
 
@@ -13,6 +14,7 @@ def initialize(*argv)
           # Extra environment vars to add to base set.
           @environment = {}
         end
+        # rubocop :enable Lint/MissingSuper
 
         def register_spinner(_spinner, _opts = {})
           raise 'This method is not implemented for PDK::CLI::Exec::InteractiveCommand'

diff --git a/lib/pdk/config/namespace.rb b/lib/pdk/config/namespace.rb
@@ -162,7 +162,7 @@ def to_h
         new_hash = {}
         settings.each_pair { |k, v| new_hash[k] = v.value }
         @mounts.each_pair { |k, mount_point| new_hash[k] = mount_point.to_h if mount_point.include_in_parent? }
-        new_hash.delete_if { |_, v| v.nil? }
+        new_hash.compact
         new_hash
       end
 

diff --git a/lib/pdk/module/metadata.rb b/lib/pdk/module/metadata.rb
@@ -119,7 +119,7 @@ def update!(data)
       def to_json(*_args)
         require 'json'
 
-        JSON.pretty_generate(@data.dup.delete_if { |_key, value| value.nil? })
+        JSON.pretty_generate(@data.dup.compact)
       end
 
       def write!(path)