Merge pull request #402 from rodjek/pdk-575

(PDK-575) Run puppet parser validate with an dummy empty puppet.conf

lib/pdk/validate/puppet/puppet_syntax.rb

@@ -22,7 +22,11 @@ def self.spinner_text(_targets = nil)
       end
 
       def self.parse_options(_options, targets)
-        %w[parser validate].concat(targets)
+        ['parser', 'validate', '--config', null_file].concat(targets)
+      end
+
+      def self.null_file
+        Gem.win_platform? ? 'NUL' : '/dev/null'
       end
 
       def self.parse_output(report, result, targets)

spec/unit/pdk/validate/puppet_syntax_spec.rb

@@ -24,6 +24,10 @@
     let(:options) { {} }
     let(:targets) { %w[target1 target2.pp] }
 
+    before(:each) do
+      allow(Gem).to receive(:win_platform?).and_return(false)
+    end
+
     it 'invokes `puppet parser validate`' do
       expect(command_args.first(2)).to eq(%w[parser validate])
     end
@@ -36,7 +40,7 @@
       let(:options) { { auto_correct: true } }
 
       it 'has no effect' do
-        expect(command_args).to eq(%w[parser validate].concat(targets))
+        expect(command_args).to eq(%w[parser validate --config /dev/null].concat(targets))
       end
     end
   end
@@ -91,4 +95,24 @@ def mock_validate(file, line, column, message, severity)
       end
     end
   end
+
+  describe '.null_file' do
+    subject { described_class.null_file }
+
+    context 'on a Windows host' do
+      before(:each) do
+        allow(Gem).to receive(:win_platform?).and_return(true)
+      end
+
+      it { is_expected.to eq('NUL') }
+    end
+
+    context 'on a POSIX host' do
+      before(:each) do
+        allow(Gem).to receive(:win_platform?).and_return(false)
+      end
+
+      it { is_expected.to eq('/dev/null') }
+    end
+  end
 end