Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: puppetlabs/pdk
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.5.0
Choose a base ref
...
head repository: puppetlabs/pdk
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.6.0
Choose a head ref

Commits on May 18, 2022

  1. (MAINT) Test with v7

    chelnak committed May 18, 2022
    Copy the full SHA
    25b35d5 View commit details

Commits on May 19, 2022

  1. Copy the full SHA
    b21161f View commit details

Commits on May 25, 2022

  1. (PDK-1791) Bump PDK version

    This commit bumps the pdk version to 2.6.0-pre as per the post release
    guidance.
    chelnak committed May 25, 2022
    Copy the full SHA
    8c68efe View commit details

Commits on May 26, 2022

  1. Merge pull request #1176 from puppetlabs/PDK-1791-post_release_versio…

    …n_bump
    
    (PDK-1791) Bump PDK version
    LukasAud authored May 26, 2022
    Copy the full SHA
    80f0402 View commit details

Commits on Jun 24, 2022

  1. Update api_types.rb

    When installing PDK as a rubygem on windows the following error occurs "warning: Using the last argument as keyword parameters is deprecated"
    
    Updating with ** as per 
    https://docs.knapsackpro.com/2021/fix-warning-using-the-last-argument-as-keyword-parameters-is-deprecated resolves this and PDK seems to work successfully
    davidsandilands authored Jun 24, 2022
    Copy the full SHA
    15ed4e2 View commit details
  2. Copy the full SHA
    bbb4ea7 View commit details

Commits on Sep 27, 2022

  1. Copy the full SHA
    86aac70 View commit details

Commits on Sep 30, 2022

  1. Merge pull request #1185 from puppetlabs/maint-update_codeowners

    (GH-CAT-98) - Update CODEOWNERS file
    chelnak authored Sep 30, 2022
    Copy the full SHA
    ea67ce5 View commit details

Commits on Nov 4, 2022

  1. Adding more to description of puppet-syntax

    As per https://github.com/voxpupuli/puppet-syntax description, it does templates and hiera yaml too
    davidsandilands authored Nov 4, 2022
    Copy the full SHA
    b09a99a View commit details
  2. Removing reference to pmtignore

    pmtignore was removed in puppetlabs/pdk-templates#20
    davidsandilands authored Nov 4, 2022
    Copy the full SHA
    6675b9c View commit details
  3. Added missing template files

    Added additional files missing from list
    davidsandilands authored Nov 4, 2022
    Copy the full SHA
    f74af77 View commit details
  4. Changing to update .sync.yaml file

    Changing to update .sync.yaml file since the template should have it now
    davidsandilands authored Nov 4, 2022
    Copy the full SHA
    2d13060 View commit details
  5. Copy the full SHA
    2ac1d47 View commit details

Commits on Dec 15, 2022

  1. (CONT-380) Refresh CI

    In preparation for the next release this PR refreshes the current GHA
    workflow so that they are in line with other projects.
    chelnak committed Dec 15, 2022
    Copy the full SHA
    f6ee6dc View commit details
  2. Merge pull request #1192 from puppetlabs/CONT-380-update_ci

    (CONT-380) Refresh CI
    GSPatton authored Dec 15, 2022
    Copy the full SHA
    15583ca View commit details

Commits on Jan 16, 2023

  1. (CONT-422) - Prep PDK version

    This commit bumps the version number of the PDK gem.
    chelnak committed Jan 16, 2023
    Copy the full SHA
    6c23197 View commit details
  2. (CONT-422) - Bump testing dependencies

    This commit bumps some testing dependencies to ensure that the project
    is up to date with the build system.
    chelnak committed Jan 16, 2023
    Copy the full SHA
    a5469eb View commit details
  3. (CONT-422) - Bump Puppet versions

    This commit ensures that we are testing against newer versions of
    Puppet.
    chelnak committed Jan 16, 2023
    Copy the full SHA
    c55fd48 View commit details
  4. (CONT-422) - Remove references to puppet 5

    Prior to this commit, spec tests expected puppet 5
    which was removed in a previous commit.
    
    This commit fixes that and a couple of other test errors.
    GSPatton authored and chelnak committed Jan 16, 2023
    Copy the full SHA
    c39a924 View commit details
  5. Merge pull request #1195 from puppetlabs/CONT-422-release_2.6.0

    (CONT-422) PDK v2.6.0
    pmcmaw authored Jan 16, 2023
    Copy the full SHA
    ddf4151 View commit details

Commits on Jan 17, 2023

  1. (CONT-422) - PDK 2.6.0 Release Notes

    This commit updates release notes for pdk 2.6.0 .
    chelnak committed Jan 17, 2023
    Copy the full SHA
    88b91de View commit details
  2. pint -> lint

    Co-authored-by: Paula Muir <paula@puppet.com>
    chelnak and pmcmaw authored Jan 17, 2023
    Copy the full SHA
    f939cc0 View commit details
  3. Merge pull request #1196 from puppetlabs/CONT-422-2.6.0_release_notes

    (CONT-422) - PDK 2.6.0 Release Notes
    GSPatton authored Jan 17, 2023
    Copy the full SHA
    2aad356 View commit details
18 changes: 11 additions & 7 deletions .github/workflows/acceptance.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
name: "Acceptance Tests"
name: "acceptance"

on: [pull_request]
on:
pull_request:
branches:
- "main"
workflow_dispatch:

env:
BOLT_GEM: true
@@ -11,7 +15,7 @@ env:
jobs:
Acceptance:
name: 'Acceptance Tests (Ruby ${{ matrix.ruby_version }})'
runs-on: ubuntu-latest
runs-on: ubuntu-20.04
strategy:
fail-fast: false
matrix:
@@ -29,7 +33,7 @@ jobs:
with:
ruby-version: "2.7"
bundler-cache: true

- name: Provision Test Environment
run: |
echo "Provisioning using ${{ matrix.provider }}: ${{ matrix.image }}"
@@ -43,8 +47,8 @@ jobs:
bundle exec bolt command run "cd pdk && git fetch origin pull/${{ github.event.number }}/head:pdk_test_repo" --targets ssh_nodes --inventory spec/fixtures/litmus_inventory.yaml
echo "Checking out to ${{ github.event.number }}"
bundle exec bolt command run "cd pdk && git checkout pdk_test_repo" --targets ssh_nodes --inventory spec/fixtures/litmus_inventory.yaml
echo "Running bundle install in container"
echo "Running bundle install in container"
- name: Bundle Install (Test Target)
run: |
echo "Running bundle install in container"
@@ -53,7 +57,7 @@ jobs:
- name: Exec Acceptance Tests
run: |
bundle exec bolt command run 'cd pdk && CI=true bundle exec rake acceptance:local_parallel' --targets ssh_nodes --inventory spec/fixtures/litmus_inventory.yaml
- name: Tear Down
if: ${{ always() }}
run: |
49 changes: 49 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
name: "ci"

on:
push:
branches:
- "main"
pull_request:
branches:
- "main"
workflow_dispatch:

jobs:
spec:
name: "spec"
runs-on: "ubuntu-20.04"
strategy:
fail-fast: false
matrix:
ruby_version: ['2.5', '2.7']

steps:

- name: "checkout"
uses: "actions/checkout@v3"

- name: "setup ruby"
uses: "ruby/setup-ruby@v1"
with:
ruby-version: ${{ matrix.ruby_version }}
bundler-cache: true
env:
BUNDLE_WITH: "test"

- name: "bundle environment"
run: |
echo ::group::bundler environment
bundle env
echo ::endgroup::
- name: "license check"
run: bundle exec rake license_finder

- name: "rubocop"
run: |
bundle exec rubocop
- name: "spec"
run: |
bundle exec rake spec
63 changes: 0 additions & 63 deletions .github/workflows/spec.yml

This file was deleted.

19 changes: 0 additions & 19 deletions .github/workflows/stale.yml

This file was deleted.

Loading