Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing deprecated message on api_types.rb #1177

Merged
merged 1 commit into from
Jun 24, 2022
Merged

Fixing deprecated message on api_types.rb #1177

merged 1 commit into from
Jun 24, 2022

Conversation

davidsandilands
Copy link
Member

When installing PDK as a rubygem on windows the following error occurs "warning: Using the last argument as keyword parameters is deprecated"

Updating with ** as per
https://docs.knapsackpro.com/2021/fix-warning-using-the-last-argument-as-keyword-parameters-is-deprecated resolves this and PDK seems to work successfully

When installing PDK as a rubygem on windows the following error occurs "warning: Using the last argument as keyword parameters is deprecated"

Updating with ** as per 
https://docs.knapsackpro.com/2021/fix-warning-using-the-last-argument-as-keyword-parameters-is-deprecated resolves this and PDK seems to work successfully
@davidsandilands davidsandilands requested a review from a team as a code owner June 24, 2022 14:59
Copy link
Contributor

@chelnak chelnak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine! Thanks 🙏

@chelnak chelnak added the bug label Jun 24, 2022
@chelnak chelnak merged commit bbb4ea7 into main Jun 24, 2022
@chelnak chelnak deleted the depreciation-fix branch June 24, 2022 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants