Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(UI) Remove UTF-8 "smart quotes" from PDK output #806

Closed
glennsarti opened this issue Nov 21, 2019 · 0 comments · Fixed by #807
Closed

(UI) Remove UTF-8 "smart quotes" from PDK output #806

glennsarti opened this issue Nov 21, 2019 · 0 comments · Fixed by #807
Labels
bug
Milestone
December 2019

Comments

@glennsarti
Copy link
Contributor

When running pdk module build I receive the following

C:\Source\tmp\pdk_release\puppetlabs-inifile [master ≡ +2 ~3 -0 !]> pdk module build
pdk (WARN): Modules are built using the â?~pdk buildâ?T command.

Note the funny looking characters â?~ and â?T

This is due to the "smart quotes" in

pdk/lib/pdk/cli/module/build.rb

Line 8 in c9a7ae5

PDK.logger.warn(_('Modules are built using the ‘pdk build’ command.'))

We should probably do an audit and get rid of "smart quotes" as they don't render in some terminals

Windows 10 - 1803 - powershell.exe
PDK 1.14.1
@glennsarti glennsarti added bug needs-triage Newly created issue that has not been reviewed by a PDK contributor labels Nov 21, 2019
@rodjek rodjek removed the needs-triage Newly created issue that has not been reviewed by a PDK contributor label Nov 21, 2019
@rodjek rodjek added this to the December 2019 milestone Nov 21, 2019
rodjek added a commit to rodjek/pdk that referenced this issue Nov 21, 2019
@rodjek
(puppetlabs#806) Use ASCII quotes instead of Unicode quotes
398b9f1
@rodjek rodjek mentioned this issue Nov 22, 2019
Merged
rodjek added a commit to rodjek/pdk that referenced this issue Nov 22, 2019
@rodjek
(puppetlabs#806) Use ASCII quotes instead of Unicode quotes
4748aee
glennsarti added a commit that referenced this issue Nov 22, 2019
@glennsarti
Merge pull request #807 from rodjek/gh-806
8283205 
(#806) Use ASCII quotes instead of Unicode quotes
@rodjek rodjek changed the title (UI) Try not to use non-ASCII characters where possible (UI) Remove UTF-8 "smart quotes" from PDK output Dec 13, 2019
logicminds pushed a commit to nwops/pdk that referenced this issue Nov 30, 2020
@rodjek @logicminds
(puppetlabs#806) Use ASCII quotes instead of Unicode quotes
96897e9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
December 2019
Development

Successfully merging a pull request may close this issue.

(#806) Use ASCII quotes instead of Unicode quotes rodjek/pdk
2 participants
@rodjek @glennsarti