-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(GH-1090) Verify the changelog top most version matches the metadata version #1088
Conversation
3d07a10
to
940bdee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you are fixing two separate bugs in one PR, can you please split the changes into two commits and add the appropriate detail to the commit message? This helps with our release process
If you don't have time, I can do that instead
940bdee
to
697bc79
Compare
Hi @jpogran, |
Sets the forge-token argument in release cli command as not required so that new module interviews will not fail.
697bc79
to
2e70d47
Compare
Codecov Report
@@ Coverage Diff @@
## main #1088 +/- ##
==========================================
- Coverage 91.25% 91.25% -0.01%
==========================================
Files 137 137
Lines 5559 5569 +10
==========================================
+ Hits 5073 5082 +9
- Misses 486 487 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed up the commits, will merge when green
Closes #917 #1090