(PDK-1758) supplement in_module_root with check for metadata.json
#1154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change the `in_module_root` function looked only for specific folders within the project to determine if it was at the root. This check supplements it with a check to see if `metadata.json` is present enabling modules that only contain `/files` without looking for such a common folder name.
Codecov Report
@@ Coverage Diff @@
## main #1154 +/- ##
=======================================
Coverage 91.25% 91.25%
=======================================
Files 137 137
Lines 5580 5580
=======================================
Hits 5092 5092
Misses 488 488
Continue to review full report at Codecov.
|
sanfrancrisko
approved these changes
Nov 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change the
in_module_rootfunction looked only for specific folders within the project to determine if it was at the root.This check supplements it with a check to see if
metadata.jsonis present enabling modules that only contain/fileswithout looking for such a common folder name.