Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take "operatingsystem_support" parameter from answer.json #1165

Merged
merged 2 commits into from
Jun 14, 2023

Conversation

me-minus
Copy link
Contributor

@me-minus me-minus commented Mar 25, 2022

fixes for 'Take "operatingsystem_support" parameter from answer.json #1164 '

@me-minus me-minus requested a review from a team as a code owner March 25, 2022 15:29
@CLAassistant
Copy link

CLAassistant commented Mar 30, 2022

CLA assistant check
All committers have signed the CLA.

@me-minus me-minus force-pushed the #1164-operatingsystem_support branch from f0da5ce to 7df7274 Compare September 29, 2022 17:11
@chelnak
Copy link
Contributor

chelnak commented Sep 30, 2022

@me-minus This looks great. Would it be possible to add a spec test for this too?

@chelnak chelnak self-assigned this Sep 30, 2022
@me-minus me-minus force-pushed the #1164-operatingsystem_support branch from 7df7274 to 3b5c3c2 Compare June 9, 2023 05:52
@me-minus me-minus requested a review from a team as a code owner June 9, 2023 05:52
@chelnak chelnak closed this Jun 9, 2023
@chelnak chelnak reopened this Jun 9, 2023
@chelnak
Copy link
Contributor

chelnak commented Jun 9, 2023

@me-minus Looks like we have a few rubocop issues. Can you take a look?

@me-minus me-minus force-pushed the #1164-operatingsystem_support branch from 3b5c3c2 to 013d84f Compare June 10, 2023 09:22
@chelnak
Copy link
Contributor

chelnak commented Jun 11, 2023

I think those last failures are unavoidable right now. I'll fix up the PR on Monday and get it merged.

Thank you!

@chelnak chelnak force-pushed the #1164-operatingsystem_support branch from 013d84f to 0a6ec5c Compare June 13, 2023 12:45
@chelnak
Copy link
Contributor

chelnak commented Jun 14, 2023

@me-minus Looking good! Thanks so much for spending the time on this (and waiting)!

@chelnak chelnak merged commit 5ca0632 into puppetlabs:main Jun 14, 2023
@me-minus
Copy link
Contributor Author

Have not been able to work on this until now (had a fix-papercuts-day at work)
If you happen to go to devconf, find the crazy candy Swedes and tell them hello from me

@me-minus me-minus deleted the #1164-operatingsystem_support branch June 28, 2023 07:07
@moritzdietz
Copy link

Trying to wrap my head around this one, what do I need to put into my answers.json to make this work?

@me-minus
Copy link
Contributor Author

me-minus commented Aug 6, 2024

put something like:
"operatingsystem_support": ["Fedora","Windows","Debian based Linux"]
in your answers.json

The names are taken from lib/pdk/module/metadata.rb

@moritzdietz
Copy link

moritzdietz commented Aug 12, 2024

Thanks for getting back to my comment. I tried out your suggestion, but no luck.
I'll open a new issue with more details and maybe someone can take a look at which step I'm doing it wrong.
edit: I got it working just the way you said. What you cannot do, is specify a version -> that's where I tripped up.
But it's logical as the info is passed to the tty/prompt stuff and that can't handle this kind of data I assume

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants