-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Take "operatingsystem_support" parameter from answer.json #1165
Take "operatingsystem_support" parameter from answer.json #1165
Conversation
f0da5ce
to
7df7274
Compare
@me-minus This looks great. Would it be possible to add a spec test for this too? |
7df7274
to
3b5c3c2
Compare
@me-minus Looks like we have a few rubocop issues. Can you take a look? |
3b5c3c2
to
013d84f
Compare
I think those last failures are unavoidable right now. I'll fix up the PR on Monday and get it merged. Thank you! |
013d84f
to
0a6ec5c
Compare
@me-minus Looking good! Thanks so much for spending the time on this (and waiting)! |
Have not been able to work on this until now (had a fix-papercuts-day at work) |
Trying to wrap my head around this one, what do I need to put into my answers.json to make this work? |
put something like: The names are taken from lib/pdk/module/metadata.rb |
Thanks for getting back to my comment. I tried out your suggestion, but no luck. |
fixes for 'Take "operatingsystem_support" parameter from answer.json #1164 '