Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(CONT-719) Require JSON gem #1218

Merged
merged 1 commit into from
Mar 10, 2023
Merged

(CONT-719) Require JSON gem #1218

merged 1 commit into from
Mar 10, 2023

Conversation

chelnak
Copy link
Contributor

@chelnak chelnak commented Mar 10, 2023

Prior to this change puppet version selection via PDK_PE_VERSION would fail due to an uninitialized constant (JSON).

It would appear that 2.7 no longer lazy loads the json gem so in this change we are explicitly requiring it.

@chelnak chelnak added the bug label Mar 10, 2023
@chelnak chelnak requested a review from a team as a code owner March 10, 2023 10:07
@chelnak chelnak self-assigned this Mar 10, 2023
Prior to this change puppet version selection via PDK_PE_VERSION would
fail due to an uninitialized constant (JSON).

It would appear that 2.7 no longer lazy loads the json gem so in this
change we are explicitly requiring it.
@chelnak chelnak force-pushed the CONT-719-require_json branch from 324fc82 to 1ef1357 Compare March 10, 2023 10:12
@jordanbreen28 jordanbreen28 merged commit a383a39 into main Mar 10, 2023
@jordanbreen28 jordanbreen28 deleted the CONT-719-require_json branch March 10, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants