(GH-1210) Require uri #1220
Merged
(GH-1210) Require uri #1220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As reported in #1210, in some situations pdk will fail to publish a module due to a missing require for URI. For this specific occurance we will eventually move to the forge SDK which will elimiate the issue. However, due to some dependency constraints we cannot to that yet. This change simply adds a new require for uri, which will solve the issue described above until we are able to migrate to the Forge SDK.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #1210, in some situations pdk will fail to publish a module due to a missing require for URI.
For this specific occurance we will eventually move to the forge SDK which will elimiate the issue. However, due to some dependency constraints we cannot to that yet.
This change simply adds a new require for uri, which will solve the issue described above until we are able to migrate to the Forge SDK.