-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(CONT-755) Ruby 3 / Puppet 8 support #1230
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chelnak
force-pushed
the
CONT-755-rubocop_updates
branch
2 times, most recently
from
March 16, 2023 15:42
902cece
to
a59527e
Compare
chelnak
force-pushed
the
CONT-755-rubocop_updates
branch
8 times, most recently
from
March 31, 2023 16:11
6455211
to
a4a2bc5
Compare
chelnak
force-pushed
the
CONT-755-rubocop_updates
branch
from
April 19, 2023 16:21
a511986
to
ded3eb0
Compare
chelnak
force-pushed
the
CONT-755-rubocop_updates
branch
8 times, most recently
from
April 20, 2023 16:10
8aaa5b8
to
f240f5d
Compare
chelnak
force-pushed
the
CONT-755-rubocop_updates
branch
2 times, most recently
from
April 20, 2023 16:30
478d58a
to
4bebdbb
Compare
chelnak
changed the title
(CONT-755) Rubocop updates
(CONT-755) Ruby 3 / Puppet 8 support
Apr 20, 2023
chelnak
force-pushed
the
CONT-755-rubocop_updates
branch
from
April 20, 2023 16:34
4bebdbb
to
e938c5d
Compare
david22swan
approved these changes
Apr 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small comment but otherwise LGTM
The CI workflows set this variable for use with other tooling tests. This commit removes it from the current environment when pdk tests are being set up.
chelnak
force-pushed
the
CONT-755-rubocop_updates
branch
from
April 21, 2023 15:12
e938c5d
to
76209b9
Compare
chelnak
force-pushed
the
CONT-755-rubocop_updates
branch
from
April 21, 2023 15:18
76209b9
to
a751312
Compare
chelnak
force-pushed
the
CONT-755-rubocop_updates
branch
from
April 24, 2023 10:55
fa15cf3
to
3aa3863
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a number of changes that ensure PDK is compatible with Ruby 3 / Puppet 8.