(SDK-305) Answer file to cache module interview answers, template-url etc #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodjek
force-pushed
the
answer_file
branch
8 times, most recently
from
c4dd18c to
97a1514
Compare
|
This still WIP @rodjek ? |
rodjek
force-pushed
the
answer_file
branch
3 times, most recently
from
30493b1 to
880856b
Compare
rodjek
changed the title
rodjek
force-pushed
the
answer_file
branch
3 times, most recently
from
d0cfc95 to
6e8780e
Compare
|
@scotje not anymore :) |
|
Hahah, OK I'll take a look tomorrow then. :) |
bmjen
approved these changes
Jul 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
PDK::AnswerFileclass to handle reading and saving user-supplied answers to questions.The responses from the module interview for the following questions are saved and used as the default values for new modules:
If the license is specified on the command line with
--license, then that value is saved to the answer file as well.Additionally, if the user specifies their own module template using
--template-url, that value is also saved and used automatically for any subsequent modules.I had to add a hidden option to the CLI (
--answer-file) in order to run the acceptance tests with clean answer files. Not sure if we want to make this option visible or not (my gut reaction is to keep it hidden unless there is a need for it).