(CAT-648) - Mark release*.rb files as non-executable #1378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, the release.rb and release_spec.rb files were marked as executable. This was an error, and these files do not need to have these permissions. This commit updates the permissions of these files to match the other files found in the ./lib/pdk/cli and ./spec/unit/pdk/cli directories.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1378 +/- ##
=======================================
Coverage 88.54% 88.54%
=======================================
Files 127 127
Lines 5334 5334
=======================================
Hits 4723 4723
Misses 611 611 ☔ View full report in Codecov by Sentry. |
danadoherty639
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Prior to this PR, the release.rb and release_spec.rb files were marked as executable. This was an error, and these files do not need to have these permissions. This PR updates the permissions of these files to match the other files found in the ./lib/pdk/cli and ./spec/unit/pdk/cli directories.
Additional Context
Add any additional context about the problem here.
Related Issues (if any)
Mention any related issues or pull requests.
Checklist