Support executable templates on filesystems mounted with noexec
#1383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nabertrand
force-pushed
the
executable_templates_fix
branch
from
8472752 to
58ff660
Compare
nabertrand
force-pushed
the
executable_templates_fix
branch
from
58ff660 to
7189ddf
Compare
jordanbreen28
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use File::Stat.executable? instead of File.executable? when checking if template files have the execute bit to support filesystems mounted with noexec.
Additional Context
If the default temp directory is mounted with the
noexecflag,PDK::Util::Filesystem.executable?will returnfalseregardless of the execute mode bits. UsingFile::Stat.executable?instead correctly determines if the file has the execute bit set.Checklist