Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(CAT-2155) Remove metadata_syntax_validator parser swap to JSON::Pure #1415

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

david22swan
Copy link
Member

@david22swan david22swan commented Nov 8, 2024

JSON::Pure no longer exists within the json gem as of 2.8.0 and as such this swap has to be removed.
Screenshot 2024-11-08 at 11 36 11 AM

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified.

`JSON::Pure` no longer exists within the `json` gem as of `2.8.0` and as such this swap has to be removed.
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.48%. Comparing base (5efd5e9) to head (01ce3e9).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1415      +/-   ##
==========================================
- Coverage   88.49%   88.48%   -0.01%     
==========================================
  Files         127      127              
  Lines        5320     5317       -3     
==========================================
- Hits         4708     4705       -3     
  Misses        612      612              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@david22swan david22swan marked this pull request as ready for review November 8, 2024 12:58
@david22swan david22swan requested a review from a team as a code owner November 8, 2024 12:58
Copy link
Contributor

@gavindidrichsen gavindidrichsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gavindidrichsen gavindidrichsen merged commit 8dcfbb5 into main Nov 8, 2024
12 checks passed
@gavindidrichsen gavindidrichsen deleted the CAT-2155 branch November 8, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants