(CAT-2164) Correct yaml_syntax_validator to error on empty file
#1425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david22swan
force-pushed
the
CAT-2164
branch
from
b7d33f7 to
f622f02
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1425 +/- ##
=======================================
Coverage 88.48% 88.49%
=======================================
Files 127 127
Lines 5317 5320 +3
=======================================
+ Hits 4705 4708 +3
Misses 612 612 ☔ View full report in Codecov by Sentry. |
david22swan
force-pushed
the
CAT-2164
branch
2 times, most recently
from
45dc6b2 to
e670b27
Compare
Previously empty yaml files would pass and be accepted as valid when PDK validate was run. However this was contrasted by Puppet and the puppetserver requiring files to always contain a valid yaml and so we are updating the pdk to be in line with this.
david22swan
force-pushed
the
CAT-2164
branch
from
e670b27 to
37e28ff
Compare
danadoherty639
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously empty yaml files would pass and be accepted as valid when PDK validate was run. However this was contrasted by Puppet and the puppetserver requiring files to always contain a valid yaml and so we are updating the pdk to be in line with this.
Checklist