(SDK-329) implement running arbitrary commands in PDK's environment #179
Conversation
DavidS
force-pushed
the
sdk-329-pdk-bundle
branch
from
d6919a3 to
543b04e
Compare
README.md
Outdated
| @@ -270,13 +270,36 @@ Multiple `--format` options can be specified as long as they all have distinct o | |||
|
|
|||
| Specifies options to pass through to the actual test-runner. In the default template (and most commonly across modules), this is [rspec](https://relishapp.com/rspec/rspec-core/docs/command-line). | |||
|
|
|||
| #### `pdk bundle` command | |||
There was a problem hiding this comment.
I think this is indented one hash too many
README.md
Outdated
| @@ -270,13 +270,36 @@ Multiple `--format` options can be specified as long as they all have distinct o | |||
|
|
|||
| Specifies options to pass through to the actual test-runner. In the default template (and most commonly across modules), this is [rspec](https://relishapp.com/rspec/rspec-core/docs/command-line). | |||
|
|
|||
| #### `pdk bundle` command | |||
|
|
|||
| This experimental command allows you to execute arbitrary commands in a bundler context within the module you're currently working on. Arguments to this command are passed straight through to bundler. | |||
There was a problem hiding this comment.
The command text says this is for 'advanced users' - we might want at least that level of warning here; if not a stronger warning that the user should know what they're doing (e.g. they might install a gem to system with this command, causing problems on their machine)?
There was a problem hiding this comment.
ha, I copied it from the one heading that had it wrong. fixed both now.
DavidS
force-pushed
the
sdk-329-pdk-bundle
branch
from
543b04e to
b6ec814
Compare
README.md
Outdated
|
|
||
| This experimental command allows you to execute arbitrary commands in a bundler context within the module you're currently working on. Arguments to this command are passed straight through to bundler. | ||
|
|
||
| Note that for most advanced uses it is required to use the `--` to separate bundler options from pdk options. Compare the following two commands: |
There was a problem hiding this comment.
The command text says this is for 'advanced users' - we might want at least that level of warning here; if not a stronger warning that the user should know what they're doing (e.g. they might install a gem to system with this command, causing problems on their machine)?
There was a problem hiding this comment.
Good call. I'll make the language a bit stronger.
DavidS
force-pushed
the
sdk-329-pdk-bundle
branch
from
b6ec814 to
9178936
Compare
|
Updated, addressing all recommendations. |
No description provided.