Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(SDK-317) Replace File.writable? test with actually creating a test file #207

Merged
merged 1 commit into from
Jul 31, 2017

Conversation

scotje
Copy link
Contributor

@scotje scotje commented Jul 28, 2017

No description provided.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 88.067% when pulling b18ba99 on scotje:317_fixup_writable_test into 4aa81da on puppetlabs:master.

@rodjek
Copy link
Contributor

rodjek commented Jul 31, 2017

👍 Eventually, we should probably look at adding win32-file to the Windows package, which seems to implement many of the File methods in a way that actually supports NTFL ACLs.

@DavidS
Copy link
Contributor

DavidS commented Jul 31, 2017

The win32-* gems are spottily maintained, and nobody's stepping up to fixing their existing issues :-(

@DavidS DavidS merged commit 628d534 into puppetlabs:master Jul 31, 2017
@scotje scotje deleted the 317_fixup_writable_test branch July 31, 2017 17:38
@scotje scotje added the bug label Aug 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants