Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PDK-396) Disable spinners in debug mode #233

Merged
merged 4 commits into from
Aug 11, 2017

Conversation

rodjek
Copy link
Contributor

@rodjek rodjek commented Aug 9, 2017

Disables the spinners if running with --debug. We already add a message to the debug log when starting a new process, so I've added another message to the debug log for when the process exits.

In parallel mode, without specifying the command, there would be no clue
which command finished.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.4%) to 93.698% when pulling 89e5b2e on rodjek:pdk-396 into 3b2265d on puppetlabs:master.

@puppetlabs puppetlabs deleted a comment from coveralls Aug 11, 2017
@puppetlabs puppetlabs deleted a comment from coveralls Aug 11, 2017
Copy link

@james-stocks james-stocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@james-stocks james-stocks merged commit f2cbe1f into puppetlabs:master Aug 11, 2017
@rodjek rodjek deleted the pdk-396 branch November 26, 2018 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants